Skip to content

[Tavern] Format GCPPubsub topic ID #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KCarretto merged 3 commits into from
Jan 7, 2025
Merged

[Tavern] Format GCPPubsub topic ID #822

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e8ff4f
better logging, attempt to fix topic id
KCarretto Jan 7, 2025
28098d9
ah, need to strip the pre-added prefix
KCarretto Jan 7, 2025
f866748
Merge branch 'main' into fix-pubsub-again
KCarretto Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tavern/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,8 @@ func (cfg *Config) NewShellMuxes(ctx context.Context) (wsMux *stream.Mux, grpcMu
return name
}

shellInputTopic := client.Topic(strings.TrimPrefix(topicShellInput, "gcppubsub://"))
shellOutputTopic := client.Topic(strings.TrimPrefix(topicShellOutput, "gcppubsub://"))
shellInputTopic := client.Topic(strings.TrimPrefix(topicShellInput, fmt.Sprintf("gcppubsub://projects/%s/topics/", projectID)))
shellOutputTopic := client.Topic(strings.TrimPrefix(topicShellOutput, fmt.Sprintf("gcppubsub://projects/%s/topics/", projectID)))

// Overwrite env var specification with newly created GCP PubSub Subscriptions
subShellInput = fmt.Sprintf("gcpubsub://%s", createGCPSubscription(ctx, EnvPubSubSubscriptionShellInput, shellInputTopic))
Expand Down
Loading