Conversation
hulto
force-pushed
the
fix-utf8-decode-error
branch
from
2d4b89a to
b365adc
Compare
KCarretto
approved these changes
Jan 26, 2025
| result_string = | ||
| String::from(String::from_utf8(response_buffer.to_vec())?.trim_matches(char::from(0))); | ||
| result_string = String::from( | ||
| String::from_utf8_lossy(&response_buffer) |
Collaborator
There was a problem hiding this comment.
Can we do debug logging for when this happens? Might be a pain if this fails silently and causes other errors downstream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Some windows commands specificall
tree C:\\Users\\testuser\\return characters outside the utf8 standard.Instead of switching to utf16 or trying different decode methods this solution replaces unknown characters with a place holder.
This avoids the function crashing and doesn't increase code complexity.
Which issue(s) this PR fixes:
Fixes #