[Tavern] Create Unique Pubsub Subscriptions#816
Merged
Conversation
Cictrone
reviewed
Jan 6, 2025
Cictrone
previously approved these changes
Jan 6, 2025
jabbate19
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tavern instance
What type of PR is this?
/kind bug
What this PR does / why we need it:
Updates Tavern to connect and create a new unique pubsub subscription for each instance of Tavern. The subscriptions are currently configured to expire after 1 day of inactivity. This is necessary because GCP Pubsub load-balances messages across all subscribers that share the same subscription, meaning for reverse shells when multiple instances of tavern are running they each only get a fragment of the messages (and therefore the shell works very poorly with more than one running instance). Read more here: https://cloud.google.com/pubsub/docs/pubsub-basics#choose_a_publish_and_subscribe_pattern