Skip to content

Comments

Fix CI failing by hard pinning derive_more version#782

Merged
hulto merged 4 commits intomainfrom
debug-ci-failure
Jun 19, 2024
Merged

Fix CI failing by hard pinning derive_more version#782
hulto merged 4 commits intomainfrom
debug-ci-failure

Conversation

@hulto
Copy link
Collaborator

@hulto hulto commented Jun 19, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

  • Update code gen'd files for rust.
  • CI started failing out of nowhere with errors:
error: Proper syntax: #[display(fmt = "My format", "arg1", "arg2")]
  --> lib/eldritch/src/lib.rs:91:19
   |
91 |         #[display(fmt = stringify!($name))]
   |                   ^^^
   |
  ::: lib/eldritch/src/assets/mod.rs:30:1
   |
30 | crate::eldritch_lib!(AssetsLibrary, "assets_library");
   | ----------------------------------------------------- in this macro invocation
   |
   = note: this error originates in the macro `crate::eldritch_lib` (in Nightly builds, run with -Z macro-backtrace for more info)

Causing cascading isssues such as:

error[E0277]: `AssetsLibrary` doesn't implement `std::fmt::Display`
  --> lib/eldritch/src/lib.rs:88:13
   |
88 |             starlark::values::NoSerialize,
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `AssetsLibrary` cannot be formatted with the default formatter
   |
  ::: lib/eldritch/src/assets/mod.rs:30:1
   |
30 | crate::eldritch_lib!(AssetsLibrary, "assets_library");
   | ----------------------------------------------------- in this macro invocation
   |
   = help: the trait `std::fmt::Display` is not implemented for `AssetsLibrary`
   = note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead
   = help: see issue #48214
   = note: this error originates in the derive macro `starlark::values::NoSerialize` which comes from the expansion of the macro `crate::eldritch_lib` (in Nightly builds, run with -Z macro-backtrace for more info)

Identified the source being:
realm/implants/lib/eldritch/src/lib.rs:93
derive_more::Display not working with stringify!($name)

https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html
Cargo assumes that all crates adhere to semver wherein breaking changes are only pushed with a major number change.

In this case a breaking change was pushed to a patch version of 0.99.17 ---> 0.99.18.
This PR specifically pins 0.99.17 of derive_more.

@hulto hulto force-pushed the debug-ci-failure branch 2 times, most recently from bd88f1b to 7f26f95 Compare June 19, 2024 19:30
@hulto hulto force-pushed the debug-ci-failure branch from da8bfd1 to 77deac7 Compare June 19, 2024 20:02
@hulto hulto changed the title Trigger Build Fix derive_more not doing semver 😠 Jun 19, 2024
@hulto hulto changed the title Fix derive_more not doing semver 😠 Fix CI failing by hard pinning derive_more version Jun 19, 2024
Copy link
Collaborator

@jabbate19 jabbate19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@hulto hulto merged commit 3b8e57c into main Jun 19, 2024
@hulto hulto deleted the debug-ci-failure branch June 19, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants