Skip to content

Comments

Fix buildrs dll build#772

Merged
Cictrone merged 30 commits intomainfrom
fix-buildrs-dll-build
May 26, 2024
Merged

Fix buildrs dll build#772
Cictrone merged 30 commits intomainfrom
fix-buildrs-dll-build

Conversation

@hulto
Copy link
Collaborator

@hulto hulto commented May 5, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  • Automatically builds the reflective loader when eldritch builds.
  • Allow users to compile imix as a DLL
  • Enforce successful cargo fmt during testing
  • Formats code
  • TODO: Enforce cargo clippy during testing.

Which issue(s) this PR fixes:

@hulto hulto mentioned this pull request May 6, 2024
Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think in the future PRs like this need to be broken up by thing its solving a bit more. theres like 3 different "goals" of the PR which kind of tethers them all together for merge/harder to review.

@Cictrone Cictrone merged commit bb49164 into main May 26, 2024
@Cictrone Cictrone deleted the fix-buildrs-dll-build branch May 26, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants