[bug] Allow GraphQL & CDN to be accessed by unactivated users#720
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #720 +/- ##
==========================================
+ Coverage 69.22% 69.24% +0.02%
==========================================
Files 179 179
Lines 12720 12731 +11
==========================================
+ Hits 8805 8816 +11
Misses 3688 3688
Partials 227 227 ☔ View full report in Codecov by Sentry. |
hulto
reviewed
Mar 22, 2024
hulto
approved these changes
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Allows
/graphqland/cdn/endpoints to be accessed by unactivated users. In the case of GraphQL, it performs it's own authorization such that unactivated users can run themequery and see their own information. For/cdn/only file downloads may be unauthenticated and unactivated, since currently Agents do not perform any authentication.