Conversation
Cictrone
commented
Mar 14, 2024
| "rust-analyzer" | ||
| ], | ||
| "rust-analyzer.check.command": "clippy", | ||
| "rust-analyzer.showUnlinkedFileNotification": false, |
Collaborator
Author
There was a problem hiding this comment.
this stops an annoying and not very useful vs code pop-up. I would like to leave it in but if we don't want to I'll remove it.
Collaborator
Author
|
Some output for what it looks like while Imix waits for the box to have an IP: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #711 +/- ##
==========================================
- Coverage 72.06% 71.95% -0.12%
==========================================
Files 175 175
Lines 12232 12251 +19
==========================================
Hits 8815 8815
- Misses 3202 3221 +19
Partials 215 215 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
As documented in #704, we were seeing that Imix would sometimes check in faster than the networking stack would complete DHCP on some boxes. To solve this we will just refresh our
primary_ipwith each callback.Which issue(s) this PR fixes:
Fixes #704