Skip to content

Comments

fix(repo): Remove ref to first party if no tomes found#698

Merged
cmp5987 merged 1 commit intomainfrom
cp-hide-first-party
Mar 10, 2024
Merged

fix(repo): Remove ref to first party if no tomes found#698
cmp5987 merged 1 commit intomainfrom
cp-hide-first-party

Conversation

@cmp5987
Copy link
Collaborator

@cmp5987 cmp5987 commented Mar 10, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  • Hides first row in repos (first party) where it references spellshift/realm tomes if there are no tomes there.

@cmp5987 cmp5987 requested a review from hulto March 10, 2024 20:33
@codecov
Copy link

codecov bot commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.06%. Comparing base (aaa84f3) to head (9cb124d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #698   +/-   ##
=======================================
  Coverage   72.06%   72.06%           
=======================================
  Files         175      175           
  Lines       12232    12232           
=======================================
  Hits         8815     8815           
  Misses       3202     3202           
  Partials      215      215           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmp5987 cmp5987 merged commit b2aa17e into main Mar 10, 2024
@cmp5987 cmp5987 deleted the cp-hide-first-party branch March 10, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants