Skip to content

Comments

Cp add quest beacon filter#697

Merged
cmp5987 merged 2 commits intomainfrom
cp-add-quest-beacon-filter
Mar 10, 2024
Merged

Cp add quest beacon filter#697
cmp5987 merged 2 commits intomainfrom
cp-add-quest-beacon-filter

Conversation

@cmp5987
Copy link
Collaborator

@cmp5987 cmp5987 commented Mar 10, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Adds beacon filter to quest view
  • Filters down counts of quests' tasks by beacon filter
  • Moves useQuest to global hooks
  • Adds optional pagination to useQuest
  • Adds fetching of location state to useQuests
  • Adds filtering to CreateQuestDropdown to only match current Quest Beacon Filters

Screenshots

Screenshot 2024-03-10 at 12 09 21 AM Screenshot 2024-03-10 at 12 09 17 AM Screenshot 2024-03-10 at 12 09 11 AM Screenshot 2024-03-10 at 12 09 04 AM

@cmp5987 cmp5987 requested a review from hulto March 10, 2024 05:20
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking stellar ✨

Copy link
Collaborator

@raynecafaro raynecafaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like javascript

@codecov
Copy link

codecov bot commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.06%. Comparing base (d033249) to head (3605fb8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #697   +/-   ##
=======================================
  Coverage   72.06%   72.06%           
=======================================
  Files         175      175           
  Lines       12232    12232           
=======================================
  Hits         8815     8815           
  Misses       3202     3202           
  Partials      215      215           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmp5987 cmp5987 merged commit aaa84f3 into main Mar 10, 2024
@cmp5987 cmp5987 deleted the cp-add-quest-beacon-filter branch March 10, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants