Skip to content

Comments

[feature] Enable Quest Tasks Relay Connection#693

Merged
KCarretto merged 3 commits intomainfrom
quest-tasks-subfiltering
Mar 6, 2024
Merged

[feature] Enable Quest Tasks Relay Connection#693
KCarretto merged 3 commits intomainfrom
quest-tasks-subfiltering

Conversation

@KCarretto
Copy link
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

Updates the tasks subfield on Quest to be a Relay Connection, enabling nested filters and pagination.

Which issue(s) this PR fixes:

Fixes #692

@codecov
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.06%. Comparing base (a5f431e) to head (b4c0a74).

Files Patch % Lines
tavern/internal/ent/schema/quest.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #693      +/-   ##
==========================================
- Coverage   72.07%   72.06%   -0.01%     
==========================================
  Files         175      175              
  Lines       12231    12232       +1     
==========================================
  Hits         8815     8815              
- Misses       3201     3202       +1     
  Partials      215      215              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmp5987 cmp5987 self-requested a review March 6, 2024 03:22
Copy link
Collaborator

@cmp5987 cmp5987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added UI fixes and updated quest view to use sub filter

@KCarretto KCarretto merged commit d033249 into main Mar 6, 2024
@KCarretto KCarretto deleted the quest-tasks-subfiltering branch March 6, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] Add sub field filtering for quests

2 participants