Skip to content

Comments

fix(bug): Add validation before rendering task#655

Merged
hulto merged 1 commit intomainfrom
cp-fix-bug
Feb 23, 2024
Merged

fix(bug): Add validation before rendering task#655
hulto merged 1 commit intomainfrom
cp-fix-bug

Conversation

@cmp5987
Copy link
Collaborator

@cmp5987 cmp5987 commented Feb 23, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

  • Fixes issue where TaskOutput should only be rendered if isOpen is true

@cmp5987 cmp5987 requested a review from hulto February 23, 2024 21:27
@codecov
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.98%. Comparing base (0f80eb2) to head (4ab579e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #655   +/-   ##
=======================================
  Coverage   71.98%   71.98%           
=======================================
  Files         174      174           
  Lines       11974    11974           
=======================================
  Hits         8619     8619           
  Misses       3141     3141           
  Partials      214      214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hulto hulto merged commit 8439148 into main Feb 23, 2024
@hulto hulto deleted the cp-fix-bug branch February 23, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants