Skip to content

[bug] Redirect existing users on new login #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KCarretto merged 1 commit into from
Feb 23, 2024
Merged

[bug] Redirect existing users on new login #654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tavern/internal/auth/oauth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ func NewOAuthAuthorizationHandler(cfg oauth2.Config, pubKey ed25519.PublicKey, g
Expires: time.Now().AddDate(0, 1, 0),
})
log.Printf("[INFO] [OAuth] new login for user %q", usr.Name)
http.Redirect(w, req, "/", http.StatusFound)
return
}

Expand Down
2 changes: 1 addition & 1 deletion tavern/internal/auth/oauth_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ func TestNewOAuthAuthorizationHandler(t *testing.T) {
req = getOAuthAuthorizationRequest(t, privKey, expectedCode)
handler.ServeHTTP(resp, req)
result = resp.Result()
require.Equal(t, http.StatusOK, result.StatusCode)
require.Equal(t, http.StatusFound, result.StatusCode)

// User assertions
assert.Equal(t, 1, graph.User.Query().CountX(context.Background()))
Expand Down