Merged
Conversation
Cictrone
approved these changes
Feb 21, 2024
Collaborator
|
windows failing! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
=======================================
Coverage 72.06% 72.06%
=======================================
Files 174 174
Lines 11964 11968 +4
=======================================
+ Hits 8622 8625 +3
- Misses 3128 3129 +1
Partials 214 214 ☔ View full report in Codecov by Sentry. |
Cictrone
previously approved these changes
Feb 21, 2024
KCarretto
dismissed
Cictrone’s stale review
The merge-base changed after approval.
KCarretto
approved these changes
Feb 21, 2024
KCarretto
deleted the
624-download-and-execute-tome-doesnt-cleanup-tmp-file
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes linux disown not working.