Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #641 +/- ##
==========================================
+ Coverage 72.15% 73.05% +0.89%
==========================================
Files 174 175 +1
Lines 11937 12342 +405
==========================================
+ Hits 8613 9016 +403
- Misses 3110 3111 +1
- Partials 214 215 +1 ☔ View full report in Codecov by Sentry. |
hulto
requested changes
Feb 21, 2024
hulto
reviewed
Apr 17, 2024
Collaborator
|
Will leave this review to @hulto |
hulto
requested changes
Jan 26, 2025
| use crate::runtime::Message; | ||
|
|
||
| #[tokio::test] | ||
| #[cfg(unix)] |
Collaborator
There was a problem hiding this comment.
Can we add windows support here too?
Collaborator
Author
|
Failure appears unrelated |
hulto
previously approved these changes
May 4, 2025
Message Enum usage changed since last time this branch was worked on. After merging main into this, the tests were breaking
hulto
approved these changes
Nov 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix Bug
Which issue(s) this PR fixes:
Fixes #428