Skip to content

Remove lint warns #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Cictrone merged 2 commits into from
Feb 21, 2024
Merged

Remove lint warns #639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c6c033
Fxed?
hulto Feb 21, 2024
590f53d
Merge branch 'main' into 631-bug-recent-changes-caused-lint-problems
Cictrone Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions implants/lib/eldritch/src/file/read_impl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,7 @@
use anyhow::{Context, Result};
use anyhow::Result;
use glob::{glob, GlobError};
use std::{fs, path::PathBuf};

/*
if !entry_path.exists() {
return Err(anyhow::anyhow!(
"file.read: pattern {} could not find path {}",
path,
entry_path.to_str().context("Failed to convert to str")?
));
}
*/

pub fn read(path: String) -> Result<String> {
let mut res: String = String::from("");
let glob_res = glob(&path)?.collect::<Vec<Result<PathBuf, GlobError>>>();
Expand Down
2 changes: 1 addition & 1 deletion implants/lib/eldritch/src/runtime/eval.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ pub struct Runtime {
#[starlark_module]
fn error_handler(builder: &mut GlobalsBuilder) {
#[allow(unused_variables)]
fn eprint(starlark_eval: &mut Evaluator<'v, '_>, message: String) -> anyhow::Result<NoneType> {
fn eprint(starlark_eval: &mut Evaluator<'_, '_>, message: String) -> anyhow::Result<NoneType> {
let env = crate::runtime::Environment::from_extra(starlark_eval.extra)?;
eprint_impl::eprint(env, message)?;
Ok(NoneType {})
Expand Down