Skip to content

Comments

Added the http.get and http.post functions with query params, headers, form, bodies as optional params (depending on GET vs POST)#636

Merged
Cictrone merged 6 commits intomainfrom
http-get
Feb 21, 2024
Merged

Added the http.get and http.post functions with query params, headers, form, bodies as optional params (depending on GET vs POST)#636
Cictrone merged 6 commits intomainfrom
http-get

Conversation

@Cictrone
Copy link
Collaborator

What type of PR is this?

/kind feature
/kind eldritch-function

What this PR does / why we need it:

It will be useful to issue HTTP GET requests from imix.

@codecov
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0892744) 71.35% compared to head (420b1a2) 72.14%.

Files Patch % Lines
implants/lib/eldritch/src/http/get_impl.rs 99.37% 1 Missing ⚠️
implants/lib/eldritch/src/http/post_impl.rs 99.42% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
+ Coverage   71.35%   72.14%   +0.79%     
==========================================
  Files         172      174       +2     
  Lines       11598    11935     +337     
==========================================
+ Hits         8276     8611     +335     
- Misses       3108     3110       +2     
  Partials      214      214              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cictrone Cictrone requested review from KCarretto and hulto February 20, 2024 21:57
@Cictrone Cictrone changed the title Added the http.get function with query params and headers as optional params Added the http.get and http.post functions with query params, headers, form, bodies as optional params (depending on GET vs POST) Feb 20, 2024
Copy link
Collaborator

@KCarretto KCarretto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

@Cictrone Cictrone merged commit 533e178 into main Feb 21, 2024
@Cictrone Cictrone deleted the http-get branch February 21, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants