Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #611 +/- ##
==========================================
+ Coverage 71.24% 71.35% +0.10%
==========================================
Files 168 169 +1
Lines 11224 11265 +41
==========================================
+ Hits 7997 8038 +41
Misses 3023 3023
Partials 204 204 ☔ View full report in Codecov by Sentry. |
KCarretto
reviewed
Feb 19, 2024
KCarretto
reviewed
Feb 19, 2024
| #[allow(unused_variables)] | ||
| fn eprint(starlark_eval: &mut Evaluator<'v, '_>, message: String) -> anyhow::Result<NoneType> { | ||
| let env = crate::runtime::Environment::from_extra(starlark_eval.extra)?; | ||
| eprint_impl::eprint(env, message)?; |
Collaborator
There was a problem hiding this comment.
Love that we pass env here, greatly demonstrates the separation between eprint (starlark) and eprint_impl (native rust)
KCarretto
approved these changes
Feb 19, 2024
Collaborator
Author
|
Ignoring golem interactive for now tracking here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
eprintfunction to allow users to emit errors manually.eprintto a native functioneprintin golem interactive.Which issue(s) this PR fixes:
Fixes #610