Fix implants windows release workflow#582
Merged
Milkshak3s merged 2 commits intomainfrom Feb 13, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #582 +/- ##
==========================================
+ Coverage 67.68% 71.83% +4.15%
==========================================
Files 142 142
Lines 9382 9955 +573
==========================================
+ Hits 6350 7151 +801
+ Misses 2866 2638 -228
Partials 166 166 ☔ View full report in Codecov by Sentry. |
hulto
reviewed
Feb 13, 2024
| RUSTFLAGS: "-C target-feature=+crt-static" | ||
| - name: 🔨 Build Imix (DLL) | ||
| run: cargo build --lib --release | ||
| run: cargo build --lib --release --verbose --target=x86_64-pc-windows-gnu |
Collaborator
There was a problem hiding this comment.
Do we want to leave verbose in?
nullmonk
pushed a commit
that referenced
this pull request
Feb 14, 2024
Co-authored-by: Hulto <7121375+hulto@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind devops
/kind bug
What this PR does / why we need it:
This should(?) might(?) fix windows builds for implants during releases.
Tested in #581 without uploading, so I don't know if it produces the correct bin, but it does finish the build without errors.
Which issue(s) this PR fixes:
Fixes #