Skip to content

Comments

[feature] Eldritch & Imix Refactor#509

Merged
KCarretto merged 13 commits intomainfrom
rust-devs-sadge
Jan 27, 2024
Merged

[feature] Eldritch & Imix Refactor#509
KCarretto merged 13 commits intomainfrom
rust-devs-sadge

Conversation

@KCarretto
Copy link
Collaborator

@KCarretto KCarretto commented Jan 27, 2024

What type of PR is this?

What this PR does / why we need it:

  • Implements an eldritch::Runtime
  • Refactors imix and eldritch
  • Refactors our protobufs
  • What doesn't it do might be a shorter answer

Cictrone
Cictrone requested changes Jan 27, 2024
View reviewed changes
implants/imix/src/install.rs
@@ -1,127 +0,0 @@
use std::collections::HashMap;
Copy link
Collaborator

@Cictrone Cictrone Jan 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

install is gone D:

Cictrone
Cictrone requested changes Jan 27, 2024
View reviewed changes
Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uno más

Cictrone
Cictrone previously approved these changes Jan 27, 2024
View reviewed changes
Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KCarretto KCarretto merged commit bfd1eb9 into main Jan 27, 2024
@KCarretto KCarretto deleted the rust-devs-sadge branch January 27, 2024 06:15
KCarretto added a commit that referenced this pull request Feb 1, 2024
@KCarretto
66b48bf 
 
[feature] Eldritch & Imix Refactor (#509)

* Refactors eldritch, introduces `eldritch::Runtime`
* Refactors imix, introduces `imix::Agent` and `imix::Config`
* Refactors our protobufs, creating new `eldritch` package for language specific types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cictrone Cictrone Cictrone left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KCarretto @Cictrone