Merged
Conversation
Added eldritch code and metadata
hulto
reviewed
Jan 26, 2024
Collaborator
hulto
left a comment
hulto
left a comment
There was a problem hiding this comment.
I'll test when I get home but looks very promising
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
=======================================
Coverage 70.52% 70.52%
=======================================
Files 126 126
Lines 9591 9591
=======================================
Hits 6764 6764
Misses 2681 2681
Partials 146 146 ☔ View full report in Codecov by Sentry. |
hulto
approved these changes
Jan 28, 2024
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Added tome for getting process information or the current process if -1 is specified. I tried a few different formats for the output think this one looks okay but let me know if you think it needs tweaking. Also the eldritch documentation indicates that the "cmd" and "environ" keys in the dict should be list/arrays but currently they're just one big string.
Which issue(s) this PR fixes:
Fixes #490