Merged
Conversation
Added eldritch code and metadata.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #505 +/- ##
=======================================
Coverage 70.91% 70.91%
=======================================
Files 126 126
Lines 10001 10001
=======================================
Hits 7092 7092
Misses 2764 2764
Partials 145 145 ☔ View full report in Codecov by Sentry. |
hulto
previously approved these changes
Jan 26, 2024
Collaborator
hulto
left a comment
hulto
left a comment
There was a problem hiding this comment.
Approving to unblock but please see change request.
| else: | ||
| print("{}: {}\n".format(key, value)) | ||
| print("\n") | ||
| print("Hostname:\n\n" + sys.hostname()) |
Collaborator
There was a problem hiding this comment.
One nit.
Can we put hostname in line with the header as you do with mac and ip.
Should just be moving the newlines to the end.
Eg. Hostname: hultos-laptop
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Tome for printing hostname and interfaces
Which issue(s) this PR fixes:
Fixes #492