Add file/directory removal tome#500
Merged
hulto merged 3 commits intospellshift:mainfrom Jan 24, 2024
Merged
Conversation
Added eldritch code and yaml metadata.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
=======================================
Coverage 71.16% 71.16%
=======================================
Files 125 125
Lines 9922 9922
=======================================
Hits 7061 7061
Misses 2717 2717
Partials 144 144 ☔ View full report in Codecov by Sentry. |
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add new tome for deleting files/directories
Which issue(s) this PR fixes:
Fixes #489
Let me know if any of the metadata values need changing. Also wasn't sure what the newline padding is for but I assume it's convention. I did a quick test in the dev container and it successfully removed both files and directories.