Skip to content

Comments

Update Eldritch documentation to include all modules in module list#495

Merged
hulto merged 5 commits intospellshift:mainfrom
Alextibtab:patch-1
Jan 23, 2024
Merged

Update Eldritch documentation to include all modules in module list#495
hulto merged 5 commits intospellshift:mainfrom
Alextibtab:patch-1

Conversation

@Alextibtab
Copy link
Contributor

@Alextibtab Alextibtab commented Jan 23, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

I noticed that the eldritch module list at the top of both the developer and user guide wasn't up to date.

Fixes #
Updated the eldritch.md files in both the user-guide and dev-guide

Updated module section to include all modules
@hulto
Copy link
Collaborator

hulto commented Jan 23, 2024

Hey @Alextibtab,
Thanks for the PR. I appreciate the attention to detail!
This looks good to me gonna approve.

When you get a chance can fill out this feedback form so we can improve the developer experience:
https://forms.gle/3Rn3iQqF79B68nWJ7

@codecov
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a4e8bf3) 71.16% compared to head (7c85e99) 71.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #495   +/-   ##
=======================================
  Coverage   71.16%   71.16%           
=======================================
  Files         125      125           
  Lines        9922     9922           
=======================================
  Hits         7061     7061           
  Misses       2717     2717           
  Partials      144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alextibtab
Copy link
Contributor Author

Thanks I filled out the survey

@hulto hulto merged commit 2193142 into spellshift:main Jan 23, 2024
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Update Eldritch documentation to include all modules in module list (#495)

* Update dev-guide eldritch.md

Updated module section to include all modules

* Update user-guide eldritch.md

---------

Co-authored-by: Hulto <7121375+hulto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants