Merged
Conversation
Cictrone
reviewed
Jan 23, 2024
implants/imix/src/tasks.rs
Outdated
|
|
||
| // Loop over each line of output from the task and append it the the channel output. | ||
| queue_task_output(async_task, *task_id, running_task_res_map, loop_start_time); | ||
| let _ = queue_task_output(async_task, *task_id, running_task_res_map); |
Cictrone
previously approved these changes
Jan 23, 2024
Collaborator
Cictrone
left a comment
Cictrone
left a comment
There was a problem hiding this comment.
just one thing thats sus
Cictrone
approved these changes
Jan 23, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #481 +/- ##
==========================================
+ Coverage 69.65% 69.95% +0.30%
==========================================
Files 121 121
Lines 9531 9527 -4
==========================================
+ Hits 6639 6665 +26
+ Misses 2779 2749 -30
Partials 113 113 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds error output to the error field.
Which issue(s) this PR fixes:
Fixes #463