Skip to content

Comments

Remove file.hash for crypto.hash#477

Merged
hulto merged 4 commits intomainfrom
459-filehash-docs
Jan 23, 2024
Merged

Remove file.hash for crypto.hash#477
hulto merged 4 commits intomainfrom
459-filehash-docs

Conversation

@hulto
Copy link
Collaborator

@hulto hulto commented Jan 23, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Remove file.hash in favor of crypto hash.

Which issue(s) this PR fixes:

Fixes #459

@hulto hulto linked an issue Jan 23, 2024 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa10d30) 69.70% compared to head (026191c) 69.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
- Coverage   69.70%   69.65%   -0.06%     
==========================================
  Files         122      121       -1     
  Lines        9554     9531      -23     
==========================================
- Hits         6660     6639      -21     
+ Misses       2781     2779       -2     
  Partials      113      113              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@hulto hulto merged commit 047959e into main Jan 23, 2024
@hulto hulto deleted the 459-filehash-docs branch January 23, 2024 02:53
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Remove file.hash for crypto.hash (#477)

* Remove file.hash for crypto.hash

* Remove hash impl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File.hash docs

2 participants