[feature] Added basic validation for parameters#456
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
==========================================
- Coverage 71.32% 71.32% -0.01%
==========================================
Files 119 120 +1
Lines 9379 9411 +32
==========================================
+ Hits 6690 6712 +22
- Misses 2566 2573 +7
- Partials 123 126 +3 ☔ View full report in Codecov by Sentry. |
hulto
approved these changes
Jan 22, 2024
Collaborator
hulto
left a comment
hulto
left a comment
There was a problem hiding this comment.
One question but looks good
| }, | ||
| { | ||
| name: "Multiple", | ||
| data: `[{"name":"an-int","type":"int32"},{"name":"a-str","type": "string"}]`, |
Collaborator
There was a problem hiding this comment.
Do we actually support int type in params?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Ensures parameters & parameter definitions are valid JSON.
Which issue(s) this PR fixes:
Fixes #173