Skip to content

Comments

[feature] gRPC File Download API#447

Merged
KCarretto merged 6 commits intomainfrom
grpc-download-file
Jan 21, 2024
Merged

[feature] gRPC File Download API#447
KCarretto merged 6 commits intomainfrom
grpc-download-file

Conversation

@KCarretto
Copy link
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds a new gRPC method for downloading files.

@KCarretto KCarretto requested review from Cictrone and hulto January 21, 2024 00:51
Cictrone
Cictrone previously approved these changes Jan 21, 2024
Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure imix has that cool new method, but otherwise lgtm

Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.realm.pub/dev-guide/tavern
Should we update the docs around the download API?

hulto
hulto previously approved these changes Jan 21, 2024
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question otherwise LGTM

@codecov
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (3576b5c) 71.46% compared to head (7ff3d25) 71.30%.

Files Patch % Lines
implants/lib/c2/src/c2.rs 0.00% 24 Missing ⚠️
tavern/internal/c2/api_download_file.go 77.50% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
- Coverage   71.46%   71.30%   -0.17%     
==========================================
  Files         115      116       +1     
  Lines        8835     8900      +65     
==========================================
+ Hits         6314     6346      +32     
- Misses       2412     2442      +30     
- Partials      109      112       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KCarretto KCarretto merged commit 1b8bf51 into main Jan 21, 2024
@KCarretto KCarretto deleted the grpc-download-file branch January 21, 2024 01:41
KCarretto added a commit that referenced this pull request Feb 1, 2024
 
[feature] gRPC File Download API (#447)

* created gRPC file download API

* regenerate entgo

* remove hash parameter, use gRPC headers instead

* generate rust gRPC bindings

* Updated documentation

* Rename header to sha3-256-checksum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants