Updated process list tome output (#423)#443
Conversation
hulto
left a comment
hulto
left a comment
There was a problem hiding this comment.
Hey @arunjohnkuruvilla!
Thanks for the feature. This looks really nice 🤌
Ran locally everything looks good.
When you get a chance can fill out this feedback form so we can improve the developer experience:
https://forms.gle/3Rn3iQqF79B68nWJ7
|
One change that would be nice to have (which we is an existing bug) print(current_proc_command+"\n")
...
print(current_proc_command.replace("\n","\\n")+"\n") |
| print(pad_pid(current_proc_pid)) | ||
| print(pad_pid(current_proc_ppid)) | ||
| print(pad_username(current_proc_username)) | ||
| print(current_proc_command+"\n") |
There was a problem hiding this comment.
Small change
print(current_proc_command.replace("\n","\\n")+"\n")There was a problem hiding this comment.
Pushed the change in the following commit.
|
Incredible feedback @arunjohnkuruvilla We do have a way for you to test tomes without restarting the application (however it's not documented yet 😬 ) # Run eldritch interactively - I find this useful for testing specific syntax or experimenting with dictionaries.
[realm/implants/golem]$ cargo run -- -i
# Run a specific tome - I statically set any input params in the tome first to resolve run time errors.
[realm/implants/golem]$ cargo run -- 'realm/tavern/tomes/process_list/main.eldritch'I'll include these ^ in the docs update but hope this helps. |
|
Merging because it’s awesome :D |
3 participants
What type of PR is this?
/kind bug
What this PR does / why we need it:
Update the process list tome for the output to look like the following -
PID PPID username command 53 1 root /lib/systemd/systemd-udevd 428 354 ubuntu -bashWhich issue(s) this PR fixes:
Hulto: Gonna change 423 to different tome editing so the issue stays open.