[feature] Added relay-style pagination to tasks query#418
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
==========================================
- Coverage 71.17% 71.13% -0.05%
==========================================
Files 109 109
Lines 8084 8089 +5
==========================================
Hits 5754 5754
- Misses 2221 2226 +5
Partials 109 109 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Added UI for pagination:
Expected Behavior:
Screenshot: 
ot:
|
hulto
approved these changes
Jan 1, 2024
Collaborator
hulto
left a comment
hulto
left a comment
There was a problem hiding this comment.
LGTM - seems to work in staging.
KCarretto
added a commit
that referenced
this pull request
Feb 1, 2024
[feature] Added relay-style pagination to tasks query (#418) * Added relay-style pagination to tasks query * feat(pagination): Add pagination for task page * fix(last): Bug fix to add last handling to pagination * fix(rowLimit): Change row limit * fix(count): Change counts for table to pages * fix(build): Run npm build --------- Co-authored-by: Squidli <catie@squidli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
Enables relay-style pagination for tasks query.
Which issue(s) this PR fixes:
Fixes #371