Skip to content

Comments

fix(loading): Adds loading on refetch#415

Merged
cmp5987 merged 2 commits intomainfrom
cp/add-refetch-status
Dec 27, 2023
Merged

fix(loading): Adds loading on refetch#415
cmp5987 merged 2 commits intomainfrom
cp/add-refetch-status

Conversation

@cmp5987
Copy link
Collaborator

@cmp5987 cmp5987 commented Dec 27, 2023

What type of PR is this?

/kind bug
/kind cleanup

What this PR does / why we need it:

  • Adds loading states when refetch occurs

Which issue(s) this PR fixes:

  • refetch changes based on filter bar didn't trigger reloading

@cmp5987 cmp5987 requested a review from hulto December 27, 2023 02:33
@codecov
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fc57f1e) 71.17% compared to head (5ba6876) 71.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #415   +/-   ##
=======================================
  Coverage   71.17%   71.17%           
=======================================
  Files         109      109           
  Lines        8084     8084           
=======================================
  Hits         5754     5754           
  Misses       2221     2221           
  Partials      109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmp5987 cmp5987 merged commit f207c64 into main Dec 27, 2023
@cmp5987 cmp5987 deleted the cp/add-refetch-status branch December 27, 2023 02:52
hulto pushed a commit that referenced this pull request Dec 27, 2023
* fix(loading): Adds loading on refetch

* fix(build): Ran build
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
fix(loading): Adds loading on refetch (#415)

* fix(loading): Adds loading on refetch

* fix(build): Ran build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants