Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
==========================================
+ Coverage 71.39% 71.45% +0.05%
==========================================
Files 113 115 +2
Lines 8800 8832 +32
==========================================
+ Hits 6283 6311 +28
- Misses 2408 2412 +4
Partials 109 109 ☔ View full report in Codecov by Sentry. |
hulto
approved these changes
Dec 26, 2023
Collaborator
hulto
left a comment
hulto
left a comment
There was a problem hiding this comment.
One change to docs otherwise LGTM
|
|
||
| ### time.sleep | ||
|
|
||
| `time.format_to_epoch(input: str, format: str) -> int` |
Collaborator
There was a problem hiding this comment.
Can you provide examples of the formats as well as a link to the docs on all acceptable formats whether that's the crate specific or the generic time formats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind eldritch-function
What this PR does / why we need it:
Adds methods to re-format times to/from UNIX Epoch. Uses Chrono for formatting and parsing.
Which issue(s) this PR fixes:
Fixes #77
Fixes #78