[feature] Added new Uint64 GraphQL scalar, added Interval field to Beacon#396
Merged
[feature] Added new Uint64 GraphQL scalar, added Interval field to Beacon#396
Conversation
hulto
reviewed
Dec 11, 2023
| Annotations( | ||
| entgql.Type("Uint64"), | ||
| entgql.OrderField("INTERVAL"), | ||
| entgql.Skip(entgql.SkipMutationUpdateInput), |
Collaborator
There was a problem hiding this comment.
I remember this being added to the other fields since they weren't being immutable.
This field will update. Do we still want to keep the Skip?
hulto
approved these changes
Dec 11, 2023
Collaborator
hulto
left a comment
hulto
left a comment
There was a problem hiding this comment.
One question otherwise looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Adds a new
Intervalfield to theBeacon, which will enable clients to estimate the next expected check-in time. It will also provide some more information about the frequency of callbacks, so that users can further distinguish betweenBeacons. This required adding a new Uint64 scalar to our GraphQL schema.Which issue(s) this PR fixes:
Fixes #394