Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
==========================================
+ Coverage 68.72% 71.52% +2.79%
==========================================
Files 108 109 +1
Lines 7367 8027 +660
==========================================
+ Hits 5063 5741 +678
+ Misses 2195 2177 -18
Partials 109 109 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
Use |
jabbate19
approved these changes
Dec 17, 2023
Collaborator
jabbate19
left a comment
jabbate19
left a comment
There was a problem hiding this comment.
LGTM, one small opinion
| Ok(NoneType{}) | ||
| } | ||
| fn rename(this: FileLibrary, old: String, new: String) -> anyhow::Result<NoneType> { | ||
| fn moveto(this: FileLibrary, old: String, new: String) -> anyhow::Result<NoneType> { |
Collaborator
There was a problem hiding this comment.
Imo move looks/sounds better, but up to you.
Collaborator
Author
There was a problem hiding this comment.
Ope - tried to make this change.
We made it moveto since move is a restricted word in rust.
So can't have functions named move. 💀
| a.all_true( | ||
| r#" | ||
| dir(file) == ["append", "compress", "copy", "download", "exists", "hash", "is_dir", "is_file", "list", "mkdir", "read", "remove", "rename", "replace", "replace_all", "template", "timestomp", "write"] | ||
| dir(file) == ["append", "compress", "copy", "download", "exists", "hash", "is_dir", "is_file", "list", "mkdir", "moveto", "read", "remove", "replace", "replace_all", "template", "timestomp", "write"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR allows you to use the
imix installsubcommand.The install subcommand executes embedded tomes similar to golem.
It will loop through all embedded files looking for
main.eldEach
main.eldwill execute in a new thread. This is done to allow imix to install redundantly or install additional (non dependent) tools.The install subcommand makes allows some variables to be passed form the user into the tomes through the
-cflag.When specified
input_params['custom_config']is set to the file path of the config specified Eg../imix install -c /tmp/imix-config.jsonwill result ininput_params['custom_config'] = "/tmp/imix-config.jsonTomes can parse this with the following:
A default install option is provided in this PR (sans windows). This option will install the imix agent as a service.
The install subcommand help
An example service config
{ "service_configs": [ { "name": "imix", "description": "Imix c2 agent", "executable_name": "imix", "executable_args": "" } ], "target_forward_connect_ip": "127.0.0.1", "target_name": "test1234", "callback_config": { "interval": 4, "jitter": 1, "timeout": 4, "c2_configs": [ { "priority": 1, "uri": "http://127.0.0.1:80/grpc" } ] } }Which issue(s) this PR fixes:
Fixes #374