add sys.write_reg() function to eldritch#387
Merged
adm1nPanda merged 22 commits intospellshift:mainfrom Jan 4, 2024
adm1nPanda:main
Merged
add sys.write_reg() function to eldritch#387adm1nPanda merged 22 commits intospellshift:mainfrom adm1nPanda:main
adm1nPanda merged 22 commits intospellshift:mainfrom
adm1nPanda:main
Conversation
hulto
reviewed
Dec 8, 2023
hulto
reviewed
Dec 8, 2023
hulto
reviewed
Dec 8, 2023
hulto
reviewed
Dec 8, 2023
hulto
reviewed
Dec 8, 2023
hulto
reviewed
Dec 8, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
==========================================
+ Coverage 71.13% 71.95% +0.82%
==========================================
Files 109 112 +3
Lines 8089 8729 +640
==========================================
+ Hits 5754 6281 +527
- Misses 2226 2339 +113
Partials 109 109 ☔ View full report in Codecov by Sentry. |
hulto
reviewed
Jan 4, 2024
hulto
reviewed
Jan 4, 2024
hulto
reviewed
Jan 4, 2024
Collaborator
hulto
left a comment
hulto
left a comment
There was a problem hiding this comment.
Looking really good.
Few changes.
hulto
reviewed
Jan 4, 2024
hulto
approved these changes
Jan 4, 2024
Collaborator
hulto
left a comment
hulto
left a comment
There was a problem hiding this comment.
Great work!
One note on docs but after that ship it! 🫡
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
add sys.write_reg() function to eldritch (#387) * add reg_write function * clean test function and add docs for write_reg * implement write_reg function * write_reg accepts different registry types * adding more examples for sys.write_reg() * fix errors from merge conflicts * add missing import in get_reg * cleanup and made recommended changes * fix eldritch docs * adding write_reg_str, write_reg_int and write_reg_hex functions * fix missing exposed functions in lib.rs * split write_reg functions into multiple pages * change funcs to alphabetical order * clean up docs for new functions * fix typo in docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind eldritch-function
What this PR does / why we need it:
Added sys.get_reg() function to eldritch. only installs on windows systems.
$> sys.write_reg("HKEY_CURRENT_USER","SOFTWARE\TEST1","FOO1","REG_SZ","BAR1")
"A new key has been created"
$> sys.write_reg("HKEY_CURRENT_USER","SOFTWARE\TEST1","FOO1","REG_BINARY","DEADBEEF")
"An existing key has been modified"
Which issue(s) this PR fixes:
Fixes #