Conversation
hulto
reviewed
Dec 3, 2023
implants/imix/src/main.rs
Outdated
| // Async handler for port scanning. | ||
| async fn main_loop(config_path: String, loop_count_max: Option<i32>) -> Result<()> { | ||
| let debug = false; | ||
| let debug = true; |
hulto
approved these changes
Dec 3, 2023
Collaborator
hulto
left a comment
hulto
left a comment
There was a problem hiding this comment.
Please set debug to false.
Otherwise LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes an issue with the new gRPC API, where casting an int32 caused an int overflow, resulting in task ids being incorrectly reported to the agent when claimed.