Skip to content

Comments

Add formating#379

Merged
hulto merged 16 commits intomainfrom
add-format
Nov 20, 2023
Merged

Add formating#379
hulto merged 16 commits intomainfrom
add-format

Conversation

@hulto
Copy link
Collaborator

@hulto hulto commented Nov 17, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR applies a standard rust formatting.
This does not apply clippy compliance #256

Which issue(s) this PR fixes:

Fixes #

@hulto hulto added cleanup Code cleanup and tech debt removal eldritch Related to the Eldritch language imix labels Nov 17, 2023
@codecov
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 384 lines in your changes are missing coverage. Please review.

Comparison is base (eff1829) 68.46% compared to head (a241008) 69.31%.

Files Patch % Lines
implants/golem/src/inter/eval.rs 52.69% 79 Missing ⚠️
implants/lib/eldritch/src/pivot/ssh_exec_impl.rs 56.79% 35 Missing ⚠️
implants/lib/eldritch/src/pivot/ssh_copy_impl.rs 55.55% 32 Missing ⚠️
implants/lib/eldritch/src/pivot/port_scan_impl.rs 84.61% 26 Missing ⚠️
implants/lib/eldritch/src/sys/dll_reflect_impl.rs 86.09% 26 Missing ⚠️
implants/lib/eldritch/src/pivot/arp_scan_impl.rs 50.00% 19 Missing ⚠️
implants/lib/eldritch/src/file/compress_impl.rs 69.81% 16 Missing ⚠️
implants/lib/eldritch/src/sys/get_reg_impl.rs 65.90% 15 Missing ⚠️
implants/imix/src/linux.rs 0.00% 14 Missing ⚠️
implants/lib/eldritch/src/sys/exec_impl.rs 85.39% 13 Missing ⚠️
... and 19 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
+ Coverage   68.46%   69.31%   +0.85%     
==========================================
  Files         106      106              
  Lines        7125     7769     +644     
==========================================
+ Hits         4878     5385     +507     
- Misses       2138     2275     +137     
  Partials      109      109              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, send it quik b4 something else lands

@@ -0,0 +1,78 @@
max_width = 100
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bold

@hulto hulto merged commit 569227e into main Nov 20, 2023
@hulto hulto deleted the add-format branch November 20, 2023 00:38
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Add formating (#379)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code cleanup and tech debt removal eldritch Related to the Eldritch language imix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants