Add sys.get_reg() function to eldritch.#362
Merged
hulto merged 7 commits intospellshift:mainfrom Nov 14, 2023
adm1nPanda:main
Merged
Add sys.get_reg() function to eldritch.#362hulto merged 7 commits intospellshift:mainfrom adm1nPanda:main
hulto merged 7 commits intospellshift:mainfrom
adm1nPanda:main
Conversation
Codecov Report
@@ Coverage Diff @@
## main #362 +/- ##
==========================================
- Coverage 75.13% 74.91% -0.23%
==========================================
Files 103 104 +1
Lines 6818 6892 +74
==========================================
+ Hits 5123 5163 +40
- Misses 1599 1633 +34
Partials 96 96
... and 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
hulto
requested changes
Nov 12, 2023
Collaborator
hulto
left a comment
There was a problem hiding this comment.
Couple fixes but looks really good. Love the testing 🤌
hulto
approved these changes
Nov 13, 2023
Collaborator
hulto
left a comment
There was a problem hiding this comment.
One more change to remove unwrap but then good to send 🚀
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind eldritch-function
What this PR does / why we need it:
Added sys.get_reg() function to eldritch. only installs on windows systems.
$> sys.get_reg("HKEY_LOCAL_MACHINE","SOFTWARE\Microsoft\Windows\CurrentVersion")
{
"ProgramFilesDir": "C:\Program Files",
"CommonFilesDir": "C:\Program Files\Common Files",
"ProgramFilesDir (x86)": "C:\Program Files (x86)",
"CommonFilesDir (x86)": "C:\Program Files (x86)\Common Files",
"CommonW6432Dir": "C:\Program Files\Common Files",
"DevicePath": "%SystemRoot%\inf",
"MediaPathUnexpanded": "%SystemRoot%\Media",
"ProgramFilesPath": "%ProgramFiles%",
"ProgramW6432Dir": "C:\Program Files",
"SM_ConfigureProgramsName": "Set Program Access and Defaults",
"SM_GamesName": "Games"
}
Which issue(s) this PR fixes:
Fixes #358