Skip to content

Comments

[feature] Added tasks root level query#361

Merged
KCarretto merged 3 commits intomainfrom
tasks-query
Nov 16, 2023
Merged

[feature] Added tasks root level query#361
KCarretto merged 3 commits intomainfrom
tasks-query

Conversation

@KCarretto
Copy link
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds a new tasks root level query, so that the UI can query tasks directly.

@KCarretto KCarretto requested review from cmp5987 and hulto November 8, 2023 00:55
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (b19f297) 75.42% compared to head (dfb8e02) 75.38%.

Files Patch % Lines
tavern/internal/graphql/query.resolvers.go 50.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
- Coverage   75.42%   75.38%   -0.05%     
==========================================
  Files         107      107              
  Lines        7243     7255      +12     
==========================================
+ Hits         5463     5469       +6     
- Misses       1684     1688       +4     
- Partials       96       98       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KCarretto KCarretto merged commit 2a21c02 into main Nov 16, 2023
@KCarretto KCarretto deleted the tasks-query branch November 16, 2023 22:48
KCarretto added a commit that referenced this pull request Feb 1, 2024
 
Added tasks root level query (#361)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants