Skip to content

Comments

Update dev container plugins#303

Merged
hulto merged 13 commits intomainfrom
update-dev-container
Nov 20, 2023
Merged

Update dev container plugins#303
hulto merged 13 commits intomainfrom
update-dev-container

Conversation

@hulto
Copy link
Collaborator

@hulto hulto commented Oct 4, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  • Not a fan of the vscode icons makes it kinda hard to read - would prefer to leave this an opt in thing for folks.

Which issue(s) this PR fixes:

@hulto hulto added cleanup Code cleanup and tech debt removal dev-ops labels Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (283b768) 74.94% compared to head (fbec060) 74.91%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
- Coverage   74.94%   74.91%   -0.03%     
==========================================
  Files         104      104              
  Lines        6893     6893              
==========================================
- Hits         5166     5164       -2     
- Misses       1631     1633       +2     
  Partials       96       96              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hulto hulto changed the title Resolve stash pop Update dev container plugins Oct 5, 2023
@hulto hulto requested a review from KCarretto October 28, 2023 20:21
Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>:(

@hulto hulto merged commit 1b73469 into main Nov 20, 2023
@hulto hulto deleted the update-dev-container branch November 20, 2023 04:26
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Update dev container plugins (#303)

* Disable vscode icons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code cleanup and tech debt removal dev-ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants