Skip to content

[AI] Expand Test Coverage - dsl/parser#1826

Draft
KCarretto wants to merge 1 commit intomainfrom
expand-test-coverage-dsl-parser-17867844541743023101
Draft

[AI] Expand Test Coverage - dsl/parser#1826
KCarretto wants to merge 1 commit intomainfrom
expand-test-coverage-dsl-parser-17867844541743023101

Conversation

@KCarretto
Copy link
Collaborator

This PR expands test coverage for the Eldritch DSL parser by adding a new test suite for edge cases. It also fixes a bug in argument parsing where **kwargs was not enforced as the last argument.

Changes:

  • Created implants/lib/eldritch/eldritch-core/tests/parser_edge_cases.rs.
  • Modified implants/lib/eldritch/eldritch-core/src/parser/expr.rs to enforce **kwargs positioning.

PR created automatically by Jules for task 17867844541743023101 started by @KCarretto

- Added `implants/lib/eldritch/eldritch-core/tests/parser_edge_cases.rs` to cover parser edge cases:
    - Chained comparisons
    - Complex slicing
    - Operator precedence
    - Tuple grouping
    - Deeply nested f-strings
    - Argument unpacking order
- Fixed a bug in `implants/lib/eldritch/eldritch-core/src/parser/expr.rs` where `**kwargs` was allowed to be followed by other arguments in function definitions. It now correctly returns an error.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2625    ±0 2625    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1009 2625 2625 0 0 0 0 36.0s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2625 0 0 5.2s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
TestDockerExecutor_Build_ContextCancellation 1 5.2s 5.2s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant