Conversation
- Added `implants/lib/eldritch/eldritch-core/tests/parser_edge_cases.rs` to cover parser edge cases:
- Chained comparisons
- Complex slicing
- Operator precedence
- Tuple grouping
- Deeply nested f-strings
- Argument unpacking order
- Fixed a bug in `implants/lib/eldritch/eldritch-core/src/parser/expr.rs` where `**kwargs` was allowed to be followed by other arguments in function definitions. It now correctly returns an error.
Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
This PR expands test coverage for the Eldritch DSL parser by adding a new test suite for edge cases. It also fixes a bug in argument parsing where
**kwargswas not enforced as the last argument.Changes:
implants/lib/eldritch/eldritch-core/tests/parser_edge_cases.rs.implants/lib/eldritch/eldritch-core/src/parser/expr.rsto enforce**kwargspositioning.PR created automatically by Jules for task 17867844541743023101 started by @KCarretto