Support separate error channel in StreamPrinter for imix#1821
Support separate error channel in StreamPrinter for imix#1821
Conversation
- Add `error_tx` to `StreamPrinter` to handle error messages separately. - Update `execute_task` to create an error channel and pass it to `StreamPrinter` and `spawn_output_consumer`. - Refactor `spawn_output_consumer` to use `tokio::select!` for handling both output and error streams concurrently. - Wrap error messages in `TaskError` when reporting to C2. - Add `test_task_eprint_behavior` to verify `eprint` functionality. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
1 participant
Updated
StreamPrinterinimixto support a separate error channel (error_tx). This allows output fromeprint!(and equivalent Eldritch built-ins) to be captured and reported asTaskErrors in theTaskOutputstructure, rather than being mixed with standard output. A new test case confirms thateprintmessages are correctly routed to the error field.PR created automatically by Jules for task 6216986745705561755 started by @KCarretto