Skip to content

Move SSH key copy button to left in Tome import flow#1820

Draft
KCarretto wants to merge 1 commit intomainfrom
tome-import-copy-button-7694311953337367488
Draft

Move SSH key copy button to left in Tome import flow#1820
KCarretto wants to merge 1 commit intomainfrom
tome-import-copy-button-7694311953337367488

Conversation

@KCarretto
Copy link
Collaborator

Moves the copy button for the SSH key in the "import repository tomes" flow to the left of the key and makes it slightly larger for better visibility/usability.

Changes:

  • Modified tavern/internal/www/src/components/tavern-base-ui/CodeBlock.tsx to add copyButtonPosition and copyButtonSize props.
  • Updated tavern/internal/www/src/pages/tomes/import-modal/StepAddDeploymentKey.tsx to use the new props.
  • Updated build artifacts in tavern/internal/www/build/.

PR created automatically by Jules for task 7694311953337367488 started by @KCarretto

Updates the `CodeBlock` component to support positioning the copy button
on the left and adjusting its size. Uses these new props in the
`StepAddDeploymentKey` component to move the copy button to the left
of the SSH key and make it slightly larger, as requested.

Frontend changes verified visually via Playwright screenshot.
Build artifacts updated.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2592    ±0 2592    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#995 2592 2592 0 0 0 0 21.9s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2592 0 0 5.2s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
TestDockerExecutor_Build_ContextCancellation 1 5.2s 5.2s
imix::bin/imix: install::tests::test_install_execution 3 1.1s 3.3s
imix::bin/imix: install::tests::test_install_execution 3 1.1s 3.3s
imix::bin/imix: install::tests::test_install_execution 3 1.1s 3.3s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant