Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

Expand test coverage for eldritch-core parser by adding edge case tests and fixing a bug in augmented assignment validation.


PR created automatically by Jules for task 6285212265147112375 started by @KCarretto

Added a new test suite `tests/parser_edge_cases.rs` covering:
- Invalid annotated assignments (e.g., `x: int` without value).
- Lambda syntax errors (e.g., `lambda x: int: x` causing unexpected tokens).
- Parser recovery in lists (e.g., `[1, def, 2]`).
- Statement synchronization after syntax errors.
- Invalid targets in augmented assignments (e.g., `1 += 2`).

Fixed a bug in `src/parser/stmt.rs` where augmented assignments did not validate the left-hand side, allowing invalid assignments to literals. The parser now correctly raises an "Invalid assignment target" error.

Verified tests pass with 20 consecutive runs for stability.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
3101    ±0 3101    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#568 3101 3101 0 0 0 0 30.4s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
3101 0 0 6.9s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch: pivot::port_scan_impl::tests::test_portscan_cidrparse 3 2.3s 6.9s
eldritch: pivot::port_scan_impl::tests::test_portscan_cidrparse 3 2.3s 6.9s
eldritch: pivot::port_scan_impl::tests::test_portscan_cidrparse 3 2.3s 6.9s
eldritch: pivot::ncat_impl::tests::test_ncat_send_udp 3 2.4s 6.9s
eldritch: pivot::ncat_impl::tests::test_ncat_send_udp 3 2.4s 6.9s
eldritch: pivot::ncat_impl::tests::test_ncat_send_udp 3 2.4s 6.9s
eldritch: http::post_impl::tests::test_post_with_params_and_headers 3 2.3s 6.9s
eldritch: http::post_impl::tests::test_post_with_params 3 2.3s 6.9s
eldritch: http::post_impl::tests::test_post_with_params 3 2.3s 6.9s
eldritch: http::post_impl::tests::test_post_with_params_and_headers 3 2.3s 6.9s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant