Merged
Conversation
Contributor
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
KCarretto
requested changes
Jan 16, 2026
implants/lib/pb/build.rs
Outdated
| .split_once("://") | ||
| .map(|(_, rest)| rest) | ||
| .unwrap_or(&transport.uri); | ||
| // // Map transport type to appropriate schema |
implants/lib/pb/build.rs
Outdated
|
|
||
| // Build DSN part with correct schema and query parameters | ||
| let mut dsn_part = format!("{}://{}", schema, uri_without_schema); | ||
| // let mut dsn_part = format!("{}://{}", schema, uri_without_schema); |
KCarretto
approved these changes
Jan 16, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Turns out you can't update env vars in the same build.rs.
Less cool now we just pass variables.
Which issue(s) this PR fixes:
Fixes #