Skip to content

Comments

Make sets iterable in eldritch-core#1580

Merged
nullmonk merged 1 commit intomainfrom
eldritch-core-set-iteration-3303524271954248170
Jan 15, 2026
Merged

Make sets iterable in eldritch-core#1580
nullmonk merged 1 commit intomainfrom
eldritch-core-set-iteration-3303524271954248170

Conversation

@google-labs-jules
Copy link
Contributor

Sets are now iterable in eldritch-core.
Iteration over sets is sorted/ordered.
Added a test case to verify set iteration.


PR created automatically by Jules for task 3303524271954248170 started by @KCarretto

Sets were previously not included in the list of iterable types in the `for` loop execution logic, causing a TypeError. This change adds `Value::Set` to the supported iterables, enabling iteration over sets.

Iteration over sets is deterministic and ordered (sorted), as the underlying implementation uses `BTreeSet`.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
3029    ±0 3029    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#490 3029 3029 0 0 0 0 29.4s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
3029 0 0 8.0s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch: pivot::port_scan_impl::tests::test_portscan_return_type_starlark_dict_from_interpreter 3 2.7s 8.0s
eldritch: pivot::port_scan_impl::tests::test_portscan_return_type_starlark_dict_from_interpreter 3 2.7s 8.0s
eldritch: pivot::port_scan_impl::tests::test_portscan_return_type_starlark_dict_from_interpreter 3 2.7s 8.0s
eldritch: pivot::port_scan_impl::tests::test_portscan_vec_to_int 3 2.6s 7.9s
eldritch: pivot::port_scan_impl::tests::test_portscan_vec_to_int 3 2.6s 7.9s
eldritch: pivot::port_scan_impl::tests::test_portscan_vec_to_int 3 2.6s 7.9s
eldritch: pivot::ssh_copy_impl::tests::test_pivot_ssh_copy 3 4.0s 7.9s
eldritch: pivot::ssh_copy_impl::tests::test_pivot_ssh_copy 3 4.0s 7.9s
eldritch: pivot::ssh_copy_impl::tests::test_pivot_ssh_copy 3 4.0s 7.9s
eldritch: pivot::port_scan_impl::tests::test_portscan_tcp 3 2.7s 7.9s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

Copy link
Collaborator

@nullmonk nullmonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works.

LGTM

@nullmonk nullmonk marked this pull request as ready for review January 15, 2026 20:35
@nullmonk nullmonk added this pull request to the merge queue Jan 15, 2026
Merged via the queue into main with commit 8d450af Jan 15, 2026
8 checks passed
@nullmonk nullmonk deleted the eldritch-core-set-iteration-3303524271954248170 branch January 15, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant