Conversation
Sets were previously not included in the list of iterable types in the `for` loop execution logic, causing a TypeError. This change adds `Value::Set` to the supported iterables, enabling iteration over sets. Iteration over sets is deterministic and ordered (sorted), as the underlying implementation uses `BTreeSet`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
nullmonk
left a comment
There was a problem hiding this comment.
Tested and it works.
LGTM
Sets are now iterable in
eldritch-core.Iteration over sets is sorted/ordered.
Added a test case to verify set iteration.
PR created automatically by Jules for task 3303524271954248170 started by @KCarretto