Skip to content

Comments

Fix fakelibs#1578

Merged
nullmonk merged 1 commit intomainfrom
fix-fakelibs-in-golem
Jan 16, 2026
Merged

Fix fakelibs#1578
nullmonk merged 1 commit intomainfrom
fix-fakelibs-in-golem

Conversation

@nullmonk
Copy link
Collaborator

Previously import all of fake broke golem. Break out fakes into each library

@github-actions
Copy link
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
3029    ±0 3029    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#489 3029 3029 0 0 0 0 29.7s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
3029 0 0 9.0s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch: random::string_impl::tests::test_string_length 3 6.4s 9.0s
eldritch: random::string_impl::tests::test_string_length 3 6.4s 9.0s
eldritch: random::string_impl::tests::test_string_length 3 6.4s 9.0s
eldritch-stdlib-tests: tests::test_all_tomes 3 5.3s 5.5s
eldritch-stdlib-tests: tests::test_all_tomes 3 5.3s 5.5s
eldritch-stdlib-tests: tests::test_all_tomes 3 5.3s 5.5s
eldritch: sys::dll_reflect_impl::tests::test_dll_reflect_starlark 1 5.4s 5.4s
eldritch: sys::dll_inject_impl::tests::test_dll_inject_simple 1 5.3s 5.3s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
eldritch: pivot::ncat_impl::tests::test_ncat_send_tcp 3 1.8s 5.2s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@nullmonk nullmonk added this pull request to the merge queue Jan 16, 2026
Merged via the queue into main with commit 31ffbf8 Jan 16, 2026
8 checks passed
@nullmonk nullmonk deleted the fix-fakelibs-in-golem branch January 16, 2026 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants