Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

Extracted file metadata logic to eldritch-libfile/src/std/metadata.rs and updated eldritch-libreport to populate metadata fields in report.file().


PR created automatically by Jules for task 5708222999983147810 started by @KCarretto

…etadata

Refactors file metadata extraction logic into a new `eldritch-libfile/src/std/metadata.rs` module, allowing it to be shared between `file.list()` and `report.file()`.
Updates `eldritch-libreport` to use this new module to populate the `permissions`, `owner`, and `group` fields in the `FileMetadata` protobuf message when reporting files.
Ensures cross-platform compatibility by using `nix` on Unix-like systems and providing safe fallbacks for Windows.
Fixes formatting and adds dependencies.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
3029    ±0 3029    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#487 3029 3029 0 0 0 0 29.5s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
3029 0 0 7.2s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch: process::kill_impl::tests::test_process_kill 3 2.5s 7.2s
eldritch: process::kill_impl::tests::test_process_kill 3 2.5s 7.2s
eldritch: process::kill_impl::tests::test_process_kill 3 2.5s 7.2s
eldritch: process::list_impl::tests::test_process_list 3 2.6s 7.1s
eldritch: process::list_impl::tests::test_process_list 3 2.6s 7.1s
eldritch: process::list_impl::tests::test_process_list 3 2.6s 7.1s
eldritch: process::netstat_impl::tests::test_netstat 3 2.3s 6.9s
eldritch: process::netstat_impl::tests::test_netstat 3 2.3s 6.9s
eldritch: process::netstat_impl::tests::test_netstat 3 2.3s 6.9s
eldritch: random::bool_impl::tests::test_bool 3 2.3s 6.9s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant