Skip to content

Comments

[AI] Expand Test Coverage - eldritch-core/strings#1569

Merged
KCarretto merged 1 commit intomainfrom
eldritch-core-tests-strings-13929783739314624257
Jan 15, 2026
Merged

[AI] Expand Test Coverage - eldritch-core/strings#1569
KCarretto merged 1 commit intomainfrom
eldritch-core-tests-strings-13929783739314624257

Conversation

@google-labs-jules
Copy link
Contributor

This PR increases test coverage for eldritch-core by adding a new test file tests/strings_extended_coverage.rs. It covers:

  • splitlines with various arguments.
  • title with mixed case and separators.
  • strip, lstrip, rstrip with arguments.
  • removeprefix and removesuffix.
  • format edge cases.
  • partition and rpartition.
  • Unicode handling with codepoints and elems.

PR created automatically by Jules for task 13929783739314624257 started by @KCarretto

Added comprehensive tests for string methods including splitlines, title, format, codepoints, and partitioning edge cases. Verified stability with 20 test runs.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2980    ±0 2980    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#439 2980 2980 0 0 0 0 30.5s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2980 0 0 11.8s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch-macros: tests::test_arg_parsing_option 3 3.9s 11.8s
eldritch-macros: tests::test_arg_parsing_option 3 3.9s 11.8s
eldritch-macros: tests::test_arg_parsing_option 3 3.9s 11.8s
eldritch-macros: tests::test_arg_parsing_str 3 3.8s 11.4s
eldritch-macros: tests::test_arg_parsing_str 3 3.8s 11.4s
eldritch-macros: tests::test_arg_parsing_str 3 3.8s 11.4s
eldritch: sys::dll_inject_impl::tests::test_dll_inject_simple 1 11.4s 11.4s
eldritch: sys::dll_reflect_impl::tests::test_dll_reflect_starlark 1 11.0s 11.0s
eldritch-macros: tests::test_expand_library_basic 3 3.6s 10.8s
eldritch-macros: tests::test_expand_library_basic 3 3.6s 10.8s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

@KCarretto KCarretto marked this pull request as ready for review January 14, 2026 22:25
@KCarretto KCarretto requested a review from hulto January 14, 2026 22:26
@KCarretto KCarretto enabled auto-merge January 14, 2026 22:27
@KCarretto KCarretto added this pull request to the merge queue Jan 15, 2026
Merged via the queue into main with commit 68a00fc Jan 15, 2026
8 checks passed
@KCarretto KCarretto deleted the eldritch-core-tests-strings-13929783739314624257 branch January 15, 2026 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants