Draft
Conversation
Contributor
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
hulto
reviewed
Jan 14, 2026
Collaborator
hulto
left a comment
hulto
left a comment
There was a problem hiding this comment.
Does this work on windows too?
| log::info!("Callback success"); | ||
|
|
||
| #[cfg(feature = "events")] | ||
| tokio::spawn(event::on_event("on_callback_success", BTreeMap::new())); |
Collaborator
There was a problem hiding this comment.
Do events want to be fired async?
Collaborator
Author
There was a problem hiding this comment.
My thought process was that the shouldn't hold up the process too much
| #[cfg(feature = "events")] | ||
| { | ||
| if event::load_event_script() { | ||
| tokio::spawn(crate::event::catch_signals()); |
Collaborator
There was a problem hiding this comment.
Nit: crate::event and event used I think this should just be event.
|
|
||
| The system looks for a universal event script at `on_event.eldritch` within the embedded assets. If found, this script is executed for every triggered event. | ||
|
|
||
| The script receives a global variable `input_params` containing: |
Collaborator
There was a problem hiding this comment.
Where does input_params come from?
Collaborator
Author
The callbacks will. The signals stuff won't obviously |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add event callbacks for Imix. This allows operators to do certain actions with eldritch on callbacks.
Example Use Cases