Skip to content

Comments

[AI] Expand Test Coverage - eldritch-core/operations#1565

Merged
KCarretto merged 1 commit intomainfrom
eldritch-test-coverage-ops-15393656514122785693
Jan 15, 2026
Merged

[AI] Expand Test Coverage - eldritch-core/operations#1565
KCarretto merged 1 commit intomainfrom
eldritch-test-coverage-ops-15393656514122785693

Conversation

@google-labs-jules
Copy link
Contributor

This PR increases test coverage for the Eldritch DSL core operations.
Specifically, it adds:

  • Unit tests for adjust_slice_indices in implants/lib/eldritchv2/eldritch-core/src/interpreter/operations/slicing.rs.
  • Unit tests for apply_arithmetic_op in implants/lib/eldritchv2/eldritch-core/src/interpreter/operations/arithmetic.rs.

The tests cover:

  • Standard arithmetic operations (+, -, *, /)
  • Python-compatible floor division (//) and modulo (%) behavior
  • Mixed Int/Float arithmetic
  • Division by zero error handling
  • Slice index normalization (negative indices, steps, bounds clamping)

These changes add critical coverage to core interpreter logic without modifying runtime behavior.


PR created automatically by Jules for task 15393656514122785693 started by @KCarretto

Added comprehensive unit tests for `slicing` and `arithmetic` operations in `eldritch-core`.
- `slicing.rs`: Added tests for index adjustment logic, covering edge cases like negative indices, negative steps, and out-of-bounds access.
- `arithmetic.rs`: Added tests for integer, float, and mixed-type arithmetic, including division by zero checks and verification of Python-style floor division and modulo behavior.
- Verified stability by running tests 20 times.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2995    ±0 2995    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#430 2995 2995 0 0 0 0 30.5s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2995 0 0 7.4s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch: process::kill_impl::tests::test_process_kill 3 2.5s 7.4s
eldritch: process::kill_impl::tests::test_process_kill 3 2.5s 7.4s
eldritch: process::kill_impl::tests::test_process_kill 3 2.5s 7.4s
eldritch: random::string_impl::tests::test_string_length 3 5.7s 6.5s
eldritch: random::string_impl::tests::test_string_length 3 5.7s 6.5s
eldritch: random::string_impl::tests::test_string_length 3 5.7s 6.5s
eldritch: random::string_impl::tests::test_string_uniform 3 2.2s 6.5s
eldritch: random::string_impl::tests::test_string_uniform 3 2.2s 6.5s
eldritch: random::string_impl::tests::test_string_uniform 3 2.2s 6.5s
eldritch: regex::match_all_impl::tests::test_multi_match 3 2.2s 6.5s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

@KCarretto KCarretto marked this pull request as ready for review January 14, 2026 22:22
@KCarretto KCarretto enabled auto-merge January 14, 2026 22:23
@KCarretto KCarretto requested a review from hulto January 14, 2026 22:23
@KCarretto KCarretto added this pull request to the merge queue Jan 15, 2026
Merged via the queue into main with commit c72fa74 Jan 15, 2026
8 checks passed
@KCarretto KCarretto deleted the eldritch-test-coverage-ops-15393656514122785693 branch January 15, 2026 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants